Some minor docker improvements #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmickeyb
requested changes
Jan 17, 2024
cmickeyb
force-pushed
the
msteiner.docker-improve
branch
from
0b9ecad to
155883c
Compare
|
@cmickeyb Mic, i reworked the PR after our discussion, the PR description is now updated to the current changes (which essentially should address your comments as mentioned above) |
bvavala
reviewed
Jan 23, 2024
g2flyer
force-pushed
the
msteiner.docker-improve
branch
from
f61f416 to
48829e2
Compare
cmickeyb
requested changes
Jan 23, 2024
cmickeyb
reviewed
Jan 23, 2024
cmickeyb
reviewed
Jan 23, 2024
cmickeyb
reviewed
Jan 23, 2024
cmickeyb
reviewed
Jan 24, 2024
g2flyer
force-pushed
the
msteiner.docker-improve
branch
from
3b65255 to
af054f9
Compare
g2flyer
force-pushed
the
msteiner.docker-improve
branch
2 times, most recently
from
1996be2 to
1f95831
Compare
|
@cmickeyb the latest version should address your comments and merge in the changes from your branch, with slight modifications for make.dev ... |
g2flyer
force-pushed
the
msteiner.docker-improve
branch
from
1f95831 to
6b8b36a
Compare
cmickeyb
approved these changes
Jan 29, 2024
- build only via docker (& make) and not also with docker-compose - consistent tagging - consistent support of ADD_APT_PKGS - some additional stop/clean-up targets Signed-off-by: g2flyer <[email protected]>
Signed-off-by: Mic Bowman <[email protected]>
Signed-off-by: Mic Bowman <[email protected]>
g2flyer
force-pushed
the
msteiner.docker-improve
branch
from
6b8b36a to
0fbd3ce
Compare
Signed-off-by: g2flyer <[email protected]>
g2flyer
force-pushed
the
msteiner.docker-improve
branch
from
5268461 to
7ee7223
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor improvements in docker code to
BTW: in readme i've noticed we suggest in our examples to put user-name into container names. This seems a wise idea for multi-user settings. Should we also adopt it in the makefiles? Easy to do but haven't changed it yet as i'm not sure if some other places count on the container names being what they are ...
Along the lines, the might include in name in container (and, more importantly, image) also SGX-mode (where also hw-mode in testing seems to have gone lost but see also PR#463, interpreter, ledger, ...?